Allow treating config fields as sensitive #1676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
sensitiveprop to field schema definition. Setting this prop totrueshould make inputs of typeStringmask the value to prevent leaking (eg. via screenshots or screenshare). The value is unmasked when user focuses the input to allow for easy editing / copying.Resolves #1674, hopefully
Screenshots
N/A, didn't test
Additional information
Did not test the change, please test it before merging. Especially the masking / unmasking part. I believe browsers emit
focusandblurin all scenarios.Checklist